added missing function okToGreet #5878
Conversation
the function okToGreet wasn't defined, so this example wouldn't work properly.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Hey, I'm not totally sure this adds a whole lot... I'm not opposed to it necessarily, but I think the Cool? |
|
Sorry about that, I accidentally referenced the wrong issue... my mistake :[ |
|
no problem . the issue isn't that important. just to avoid that more On Sat, 18 Jan 2014 16:12:13 -0600, Caitlin Potter
|
|
So, I've decided that I don't think defining this function in the example really adds anything useful to the example, but I think a note could be made of it (that it's expected to be in the lexical scope), does that work for you? |
|
yeah, that's fine, too On Sat, 18 Jan 2014 16:32:37 -0600, Caitlin Potter
|
|
you could also omit the function completely:
to avoid unnecessary boilerplate notes. On Sat, 18 Jan 2014 16:32:37 -0600, Caitlin Potter
|
…xample the function okToGreet wasn't defined, so this example wouldn't work properly. I've decided that instead of adding unrelated code to the example, it should just be noted that the function is expected to be defined in the lexical scope. Closes angular#5878
…xample the function okToGreet wasn't defined, so this example wouldn't work properly. I've decided that instead of adding unrelated code to the example, it should just be noted that the function is expected to be defined in the lexical scope. Closes angular#5878
the function okToGreet wasn't defined, so this example wouldn't work properly.